update lmdbdataset#2531
Merged
Merged
Conversation
Contributor
Author
|
/build |
2 similar comments
Contributor
Author
|
/build |
Contributor
|
/build |
Contributor
Contributor
Author
Nic-Ma
reviewed
Jul 7, 2021
Nic-Ma
approved these changes
Jul 8, 2021
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
added a commit
to wyli/MONAI
that referenced
this pull request
Jul 8, 2021
This reverts commit a980ae4. Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
added a commit
that referenced
this pull request
Jul 8, 2021
* adds whats new 0.6 Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update docs Signed-off-by: Wenqi Li <wenqil@nvidia.com> * add a list Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update according to comments Signed-off-by: Wenqi Li <wenqil@nvidia.com> * fixes typos Signed-off-by: Wenqi Li <wenqil@nvidia.com> * Revert "update lmdbdataset (#2531)" This reverts commit a980ae4. Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
added a commit
to wyli/MONAI
that referenced
this pull request
Jul 12, 2021
* update lmdbdataset Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update tests Signed-off-by: Wenqi Li <wenqil@nvidia.com> * docstring and less verbose progressbar Signed-off-by: Wenqi Li <wenqil@nvidia.com> * docstring Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update based on comments Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
added a commit
to wyli/MONAI
that referenced
this pull request
Jul 13, 2021
* update lmdbdataset Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update tests Signed-off-by: Wenqi Li <wenqil@nvidia.com> * docstring and less verbose progressbar Signed-off-by: Wenqi Li <wenqil@nvidia.com> * docstring Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update based on comments Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Nic-Ma
pushed a commit
that referenced
this pull request
Jul 13, 2021
* update lmdbdataset (#2531) * update lmdbdataset Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update tests Signed-off-by: Wenqi Li <wenqil@nvidia.com> * docstring and less verbose progressbar Signed-off-by: Wenqi Li <wenqil@nvidia.com> * docstring Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update based on comments Signed-off-by: Wenqi Li <wenqil@nvidia.com> * fixes lmdb integration tests Signed-off-by: Wenqi Li <wenqil@nvidia.com> * add docstring Signed-off-by: Wenqi Li <wenqil@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li wenqil@nvidia.com
this PR moves the lmdb
_fill_cache_start_readerto the dataset's constructor, otherwise multiprocess lmdb writing may slow down the loading a lotStatus
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.